Skip to content

Move to gfortran 15 on macos #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

Move to gfortran 15 on macos #924

merged 1 commit into from
Jul 8, 2025

Conversation

@sbryngelson
Copy link
Member

@sbryngelson sbryngelson commented Jul 8, 2025 •
edited by qodo-merge-pro bot
Loading

User description

MacOS runners were using gfortran 14 with an incompatible open-mpi. This PR moves us to gnu15 and fixes a build error.

PR Type

Enhancement

Description

  • Upgrade gfortran from version 14 to 15 on macOS

  • Fix compatibility issues with open-mpi

  • Add missing newline at end of file

Changes diagram

flowchart LR
  A["macOS CI Setup"] --> B["Install gcc@15"]
  B --> C["Set FC=gfortran-15"]
  C --> D["Compatible with open-mpi"]
Loading

Changes walkthrough 📝

Relevant files
Configuration changes
test.yml
Upgrade gfortran version in CI workflow                                   

.github/workflows/test.yml

  • Update brew install command to use gcc@15 instead of gcc@14
  • Change environment variable FC to gfortran-15
  • Add missing newline at end of file
    		• +3/-3     
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    Copilot AI review requested due to automatic review settings July 8, 2025 05:36
    @sbryngelson sbryngelson merged commit 0900648 into MFlowCode:master Jul 8, 2025
    12 checks passed
    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 8, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Version Compatibility

    The upgrade from gcc@14 to gcc@15 should be validated to ensure compatibility with all dependencies (fftw, hdf5, boost, open-mpi) and that the build process works correctly on macOS runners.

     
    brew install coreutils python cmake fftw hdf5 gcc@15 boost open-mpi
echo "FC=gfortran-15" >> $GITHUB_ENV

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 8, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copilot AI reviewed Jul 8, 2025
    View reviewed changes
    Copy link
    Contributor

    Copilot AI left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Pull Request Overview

    This PR updates the macOS CI runners to use GCC/GFortran 15 instead of 14, resolving an Open-MPI compatibility issue.

    • Switches the Homebrew formula from gcc@14 to gcc@15.
    • Updates the FC environment variable to gfortran-15.
    Comments suppressed due to low confidence (1)

    .github/workflows/test.yml:56

    • Consider explicitly linking gcc@15 after installation (e.g., brew link --force gcc@15) or adding its bin directory to PATH so that gfortran-15 is reliably available in subsequent steps.
              brew install coreutils python cmake fftw hdf5 gcc@15 boost open-mpi

    @codecov
    Copy link

    codecov bot commented Jul 8, 2025

    Codecov Report

    All modified and coverable lines are covered by tests ✅

    Project coverage is 43.68%. Comparing base (40c1327) to head (058a8ef).
    Report is 1 commits behind head on master.

    Additional details and impacted files 
    @@           Coverage Diff           @@
##           master     #924   +/-   ##
=======================================
  Coverage   43.68%   43.68%           
=======================================
  Files          68       68           
  Lines       18363    18363           
  Branches     2295     2295           
=======================================
  Hits         8022     8022           
  Misses       8949     8949           
  Partials     1392     1392

    ☔ View full report in Codecov by Sentry.
    📢 Have feedback on the report? Share it here.

    🚀 New features to boost your workflow:
    • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

    @sbryngelson sbryngelson deleted the gfort15 branch July 10, 2025 00:17
    prathi-wind pushed a commit to prathi-wind/MFC-prathi that referenced this pull request Jul 13, 2025
    @sbryngelson @prathi-wind
    Update test.yml (MFlowCode#924)
    1b7eb2e
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    Copilot code review Copilot Copilot left review comments

    Assignees

    No one assigned

    Labels

    Review effort 2/5

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    1 participant

    @sbryngelson